Issue Details (XML | Word | Printable)

Key: FDT-47
Type: Bug Bug
Status: Confirmed Confirmed
Resolution: none
Priority: Minor Minor
Assignee: FDT Team
Reporter: Joa Ebert
Votes: 4
Watchers: 2
Operations

If you were logged in you would be able to see more operations.
FDT

FDT does not evaluate all code paths for return values

Created: 22/Sep/08 06:15 PM   Updated: 08/Aug/12 05:05 PM
Component/s: Parser
Affects Version/s: FDT 4.5.2
Fix Version/s: FDT
Security Level: public

Time Tracking:
Not Specified

Environment: Windows
Issue Links:
Duplicate
 

Review Type: Review by Product Owner


 Description  « Hide
If a method has to return a value, FDT does not evaluate all code paths but just searches for any return statement.
Example:

function foo(): Bar

{ if(Math.random() > 0.5) return new Bar(); }

FDT shows no error, but of course that method is completly wrong.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
[ Permalink | « Hide ]
Arne Deutsch added a comment - 24/Sep/08 03:51 PM
Changed priority to "minor" ... this would be nice to have but does not result in a major loss of functionality.

Arne Deutsch made changes - 24/Sep/08 03:51 PM
Field Original Value New Value
Priority Major [ 3 ] Minor [ 4 ]
Arne Deutsch made changes - 24/Sep/08 03:51 PM
Status Open [ 1 ] Confirmed [ 10000 ]
Arne Deutsch made changes - 26/May/09 10:46 AM
Issue Type Bug [ 1 ] Improvement [ 4 ]
Sebastian Bär made changes - 14/Jun/10 04:08 PM
Assignee Philipp Arnolds [ phiarn ]
Stefan Kreus made changes - 12/Aug/10 11:17 AM
Workflow Public Product Workflow [ 10262 ] FDT Workflow [ 16442 ]
Stefan Kreus made changes - 12/Aug/10 11:34 AM
Workflow FDT Workflow [ 16442 ] FDT Workflow2 [ 17649 ]
Sebastian Bär made changes - 06/May/11 06:46 AM
Workflow FDT Workflow2 [ 17649 ] FDT Workflow3 [ 20751 ]
Sebastian Bär made changes - 12/May/11 12:07 AM
Workflow FDT Workflow3 [ 20751 ] FDT Bugs - productive [ 22801 ]
Sebastian Bär made changes - 02/Jun/11 01:38 PM
Assignee Philipp Arnolds [ phiarn ] Alan Klement [ ultraky ]
Sebastian Bär made changes - 02/Jun/11 03:58 PM
Workflow FDT Bugs - productive [ 22801 ] FDT Feature Requests - productive [ 24580 ]
Alan K (Deprecated) made changes - 04/Aug/11 07:01 PM
Affects Version/s 3.1 [ 10014 ]
Review Type Review by Product Owner
Affects Version/s FDT 4.5.2 [ 10392 ]
Fix Version/s FDT Next [ 10389 ]
Alan K (Deprecated) made changes - 08/Dec/11 07:14 PM
Component/s Core [ 10011 ]
Component/s Parser [ 10567 ]
[ Permalink | « Hide ]
Alan K (Deprecated) added a comment - 08/Dec/11 07:44 PM 
public function get someProperty() : int {
			
			// fails
			// if(myNum > .5) return 10;
			// fails
			// var myNum : Number = Math.random();
			//  if(myNum > .5) return _someProperty;
			//fails
			// if (false) return 10;
			
		}

This is a bug in the parser, as none of these examples will compile.


Alan K (Deprecated) made changes - 08/Dec/11 07:47 PM
Link This issue is duplicated by FDT-2488 [ FDT-2488 ]
[ Permalink | « Hide ]
Alan K (Deprecated) added a comment - 08/Dec/11 07:48 PM
This is a bug and moved over there.

Alan K (Deprecated) made changes - 08/Dec/11 07:48 PM
Resolution Duplicate [ 3 ]
Status Confirmed [ 10000 ] Resolved [ 5 ]
Alan K (Deprecated) made changes - 08/Dec/11 07:48 PM
Status Resolved [ 5 ] Closed [ 6 ]
Sebastian Bär made changes - 15/Mar/12 05:07 PM
Fix Version/s FDT Next [ 10389 ]
Fix Version/s 5.5 [ 10432 ]
Philipp Arnolds made changes - 08/May/12 02:29 PM
Fix Version/s 5.5 Beta [ 10432 ]
Fix Version/s FDT 5.5 [ 10491 ]
Status Closed [ 6 ] Open [ 1 ]
Alan K (Deprecated) made changes - 08/May/12 11:18 PM
Workflow FDT Feature Requests - productive [ 24580 ] FDT Bugs - productive [ 27657 ]
Issue Type Improvement [ 4 ] Bug [ 1 ]
Alan K (Deprecated) made changes - 08/May/12 11:18 PM
Fix Version/s FDT 5.5 [ 10491 ]
Fix Version/s FDT Next [ 10389 ]
Philipp Arnolds made changes - 09/May/12 10:46 AM
Resolution none [ 6 ]
Status Open [ 1 ] Confirmed [ 10000 ]
FDT Team made changes - 21/Jun/12 06:16 PM
Assignee Alan Klement [ ultraky ] FDT Team [ fdt team ]
FDT Team made changes - 04/Jul/12 04:35 PM
Status Confirmed [ 10000 ] Closed [ 6 ]
[ Permalink | « Hide ]
FDT Team added a comment - 04/Jul/12 04:39 PM
fixed

[ Permalink | « Hide ]
Damien Laurent added a comment - 08/Aug/12 04:55 PM
Hi,

There is still an issue :

private function test() : int
{
    for each ( var frameLabel : FrameLabel in currentLabels )
    {
        if ( frameLabel.name == "something" )
            return frameLabel.frame;
    }
    // An error should be displayed here, cause a return statement is missing.
}

FDT Team made changes - 08/Aug/12 05:03 PM
Status Closed [ 6 ] Under Investigation [ 10004 ]
FDT Team made changes - 08/Aug/12 05:05 PM
Status Under Investigation [ 10004 ] Confirmed [ 10000 ]

Powered by Atlassian JIRA the Professional Issue Tracker. (Enterprise Edition, Version: 3.13.5-#360) - Bug/feature request - Atlassian news - Contact Administrators